Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Issue #15; Prevent the PiGPIO library from internally handling s… #32

Merged
merged 1 commit into from
Jul 13, 2020
Merged

FIX: Issue #15; Prevent the PiGPIO library from internally handling s… #32

merged 1 commit into from
Jul 13, 2020

Conversation

savageautomate
Copy link
Member

…ignals and preventing signals from reaching the JVM.

@savageautomate
FIX: Issue #15; Prevent the PiGPIO library from internally handling s…
b3e40b7 
…ignals and preventing signals from reaching the JVM.
@savageautomate savageautomate linked an issue Jul 13, 2020 that may be closed by this pull request
Use of signal handlers needs to be improved #15
Closed
@savageautomate savageautomate self-assigned this Jul 13, 2020
@savageautomate savageautomate added the bug Something isn't working label Jul 13, 2020
@savageautomate savageautomate added this to the v2.0 (initial release) milestone Jul 13, 2020
hackerjimbo
hackerjimbo approved these changes Jul 13, 2020
View reviewed changes
Copy link

@hackerjimbo hackerjimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without these changes two test programs consistently crash out with signal 11. With they run smoothly and have done for several hours. Note that they crashed out within seconds before.

@FDelporte
Copy link
Member

Great work @savageautomate @hackerjimbo! Seems the biggest improvements only need a one line change ;-)

@FDelporte FDelporte merged commit ec7b204 into master Jul 13, 2020
@FDelporte FDelporte deleted the issue/#15 branch July 13, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackerjimbo hackerjimbo hackerjimbo approved these changes

Assignees

@savageautomate savageautomate

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0 (initial release)
Development

Successfully merging this pull request may close these issues.

Use of signal handlers needs to be improved
3 participants
@savageautomate @FDelporte @hackerjimbo