Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

[BUG] Not able to access match as SA or Admin #147

Closed
bjerrecs opened this issue Oct 19, 2019 · 8 comments
Closed

[BUG] Not able to access match as SA or Admin #147

bjerrecs opened this issue Oct 19, 2019 · 8 comments
Labels
bug Something isn't working on hold Something that is awaiting response.

Comments

@bjerrecs
Copy link

Describe the bug
Installed the Get5 Web as per standard.
Can create matches, seasons and more.

All works fine.

But i cant access the match while its live?

Here are the screenshots off the results of pressing the match ID buttom.

First screenshot of error is from superadmin and the other is from a normal admin
chrome_Zg69EGQ6PP
chrome_8HKpO1uX40
chrome_p1hd2ZTaNo

Which Build
Get5 d0477c6+

@bjerrecs bjerrecs added the bug Something isn't working label Oct 19, 2019
@bjerrecs bjerrecs changed the title [BUG] [BUG] Not able to access match as SA or Admin Oct 19, 2019
@PhlexPlexico
Copy link
Owner

PhlexPlexico commented Oct 19, 2019

Wait, actually found it. https://github.com/PhlexPlexico/get5-web/blob/master/get5/match.py#L699 just needs to be is_admin not lis_admin. Will fix.

@PhlexPlexico
Copy link
Owner

PR #148 should fix this. Please confirm, thanks!

@PhlexPlexico PhlexPlexico added the on hold Something that is awaiting response. label Oct 21, 2019
@mrc4tt
Copy link

mrc4tt commented Oct 21, 2019

I can confirm, this happens if I setting 1 match to being: Private Match

Sorry, unexpected error: 'BaseQuery' object is not callable - and this happens, if I edit on database set match 1 to being private match and clicking on the match (as admin, and I get the error!)

@PhlexPlexico
Copy link
Owner

And are you running the latest version after PR #148 was updated? If so, please supply the log at the time of error. Thanks!

@mrc4tt
Copy link

mrc4tt commented Oct 21, 2019

And are you running the latest version after PR #148 was updated? If so, please supply the log at the time of the error. Thanks!

Yes, I did installed it yesterday! ;) if I looking on Match.py (it's updated, as you did fix! with "lis_admin" to "is_admin" ;)

Pastebin for errors: https://pastebin.com/wMDyjsLp
build: a668e46

@PhlexPlexico
Copy link
Owner

PhlexPlexico commented Oct 21, 2019

For reference this is where it's failing and it's to do with logic of selecting the PlayerStats model. Will look into later.

Should maybe replace that list to combine with this: playerstats_steam = [r.steam_id for r in PlayerStats.query.filter(PlayerStats.match_id=match.id)] on that line. That may fix it.

PhlexPlexico added a commit that referenced this issue Oct 22, 2019
@PhlexPlexico
Copy link
Owner

Latest development push should fix it.

@bjerrecs
Copy link
Author

Can confirm the fix worked on my end! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working on hold Something that is awaiting response.
Projects
None yet
Development

No branches or pull requests

3 participants