V6.1 #1169
Open
V6.1 #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated field file unique id choice ui to not cut-off text
…econdary preferences fix for geonav internal gps not updating updated geonav to work with getRange db calls to reflect primary/secondary changes fixed minor geonav errors/warnings
…hoice # Conflicts: # app/src/main/java/com/fieldbook/tracker/views/RangeBoxView.kt
bugfix for saving multiple brapi studies with different attributes at once
…hoice # Conflicts: # app/src/main/java/com/fieldbook/tracker/views/RangeBoxView.kt
added new color that defines inverted crop region color updated list item image to fit center rather than crop updated camerax to 1.4.1
minor formatting for prim/sec choices added title to prim/sec choice dialog
# Conflicts: # app/src/main/java/com/fieldbook/tracker/activities/brapi/io/BrapiStudyImportActivity.kt # app/src/main/java/com/fieldbook/tracker/database/dao/StudyDao.kt # app/src/main/res/values/strings.xml
# Conflicts: # app/src/main/res/values/strings.xml
kamathprasad9
approved these changes
Feb 21, 2025
bellerbrock
approved these changes
Feb 25, 2025
| @@ -33,6 +30,8 @@ class RangeBoxView : ConstraintLayout { | |||
|
|
|||
| companion object { | |||
| const val TAG = "RangeBoxView" | |||
| //truncate to three characters plus the colon | |||
| const val TRUNCATE_LENGTH = 3 + 1 | |||
There was a problem hiding this comment.
Any reason this can't default to more characters, or be set dynamically based on screen and/or text size? With this default it cuts off strings like plot and block, yet it looks like there is still a fair amount of space left that could display them even on small screens with extra large text.
A long press word wrap option like with the infobars could be helpful for ellipsized primary/secondary values too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #270
Closes #1028
Closes #414
Closes #574
Closes #1052
Closes #1154
Change Type
ADDITION(non-breaking change that adds functionality)CHANGE(fix or feature that alters existing functionality)FIX(non-breaking change that resolves an issue)OTHER(use only for changes like tooling, build system, CI, docs, etc.)Release Note
Release Type
For internal use - please leave these unchecked unless you are the one completing the merge.
MAJORMINORWAIT(No immediate release, but the changelog will be still be updated if there is a release note.)