Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rustc nightly-2022-07-11 & Substrate to polkadot-v0.9.26 #872

Merged
merged 9 commits into from
Jul 12, 2022

Conversation

jasl
Copy link
Contributor

@jasl jasl commented Jul 11, 2022

paritytech/substrate@polkadot-v0.9.25...polkadot-v0.9.26

Notable changes:

In addition:

  • Upgrade to Ink! v3.3.0
  • Upgrade Rocket to latest for PRuntime
  • Have to use rocksdb from git to avoid zstd version conflict (they have regression test so should be OK)

There're compiling warnings not sure they're from upstream

warning: unnecessary lifetime parameter `'a`
  --> crates/pink/pink-extension/src/chain_extension/signing.rs:14:21
   |
14 | pub struct SignArgs<'a> {
   |                     ^^
   |
   = help: you can use the `'static` lifetime directly, in place of `'a`

warning: unnecessary lifetime parameter `'a`
  --> crates/pink/pink-extension/src/chain_extension/signing.rs:22:23
   |
22 | pub struct VerifyArgs<'a> {
   |                       ^^
   |
   = help: you can use the `'static` lifetime directly, in place of `'a`

warning: unnecessary lifetime parameter `'a`
  --> crates/pink/pink-extension/src/chain_extension/signing.rs:31:29
   |
31 | pub struct PublicKeyForArgs<'a> {
   |                             ^^
   |
   = help: you can use the `'static` lifetime directly, in place of `'a`

@jasl jasl changed the title Upgrade rustc & Substrate to polkadot-v0.9.25 Upgrade rustc nightly-2022-07-11 & Substrate to polkadot-v0.9.26 Jul 11, 2022
@jasl jasl requested a review from kvinwang July 11, 2022 19:49
@jasl jasl marked this pull request as ready for review July 11, 2022 19:49
@jasl jasl force-pushed the upgrade-rustc branch 2 times, most recently from 821b7a7 to 9d7d80c Compare July 11, 2022 20:36
@jasl
Copy link
Contributor Author

jasl commented Jul 12, 2022

@kvinwang CI greened

Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl enabled auto-merge July 12, 2022 12:24
@jasl jasl merged commit b58031c into master Jul 12, 2022
@jasl jasl deleted the upgrade-rustc branch July 12, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants