Refactor #133
Merged
Refactor #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peternator7
requested changes
Oct 8, 2020
|
|
||
| for meta in strum_meta { | ||
| let meta = match meta { | ||
| syn::Meta::NameValue(mv) => mv, | ||
| Meta::NameValue(mv) => mv, | ||
| _ => panic!("strum on types only supports key-values"), |
There was a problem hiding this comment.
Can we return an Err here was well?
| _ => panic!("strum on types only supports key-values"), | ||
| }; | ||
|
|
||
| if meta.path.is_ident("serialize_all") { | ||
| let style = match meta.lit { | ||
| syn::Lit::Str(s) => s.value(), | ||
| Lit::Str(s) => s.value(), | ||
| _ => panic!("expected string value for 'serialize_all'"), |
| let name = &ast.ident; | ||
| let vis = &ast.vis; | ||
|
|
||
| let variants = match ast.data { | ||
| syn::Data::Enum(ref v) => &v.variants, | ||
| Data::Enum(ref v) => &v.variants, | ||
| _ => panic!("EnumDiscriminants only works on Enums"), |
| @@ -24,17 +25,19 @@ pub fn enum_iter_inner(ast: &syn::DeriveInput) -> TokenStream { | |||
| }; | |||
|
|
|||
| let variants = match ast.data { | |||
| syn::Data::Enum(ref v) => &v.variants, | |||
| Data::Enum(ref v) => &v.variants, | |||
| _ => panic!("EnumIter only works on Enums"), | |||
There was a problem hiding this comment.
Perhaps we can use Span.call_site() as the error position here.
|
Yes, I'm planning to convert more panics to |
Peternator7
approved these changes
Oct 8, 2020
|
Change is merged. I'm going to hold off publishing a new version until the rest of your changes are in. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.