Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update MainActivity architecture #11

Merged
merged 386 commits into from
May 31, 2024
Merged

update MainActivity architecture #11

merged 386 commits into from
May 31, 2024

Conversation

PeterNaggschga
Copy link
Owner

@PeterNaggschga PeterNaggschga commented Dec 28, 2023 •
edited
Loading

  • moved to android Room for persistence and integrity
  • added testing of all classes
  • added documentation of all classes

@PeterNaggschga PeterNaggschga added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 28, 2023
@PeterNaggschga PeterNaggschga self-assigned this Dec 28, 2023
@PeterNaggschga PeterNaggschga linked an issue Dec 29, 2023 that may be closed by this pull request
save state using android tools rather than json #13
Closed
@PeterNaggschga
added documentation to MenuUiState
583bdaf 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added MenuUiStateUnitTest.java
3abc76f 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to MenuUpdateObserver
ff5cf02 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added MenuUpdateObserverUnitTest.java
3fb4655 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
renamed package ui.main to ui.onboarding
24e87fd 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
renamed moved everything belonging to the main screen and its view mo…
206ef21 
…dels to ui.main package

Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
refined testing of MenuUpdateObserver
41f59f4 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added ImageViewSwitchAnimator.java
3182729 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
used ImageViewSwitchAnimator in RowUiStateObserver
6893d1f 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
used ImageViewSwitchAnimator in MenuUiStateObserver
98b1000 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
removed unnecessary background views for weather and horn in row.xml
d5af4a3 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
clarified description of MenuUpdateObserver
6543111 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to MenuUiStateObserver
fd0d246 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added RowUiStateObserver::getObserver to simplify calculations in Row…
b245398 
…UiStateObserver::onChanged

Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
updated documentation of MenuUiStateObserver
8541b86 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation of RowUiStateObserver
6b8a19a 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added RowUiStateObserverUnitTest.java
5428b20 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added MenuUiStateObserverUnitTest.java
8e7f717 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
moved Ability.java to top level package
43a8ceb 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
moved RowType.java to top level package
b05ff3f 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to ImageViewSwitchAnimator.java
4d0bcfb 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
moved sound preference keys and default values to preferences.xml
0346dab 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added Sound.java
200b44e 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added SoundManager.java
17f2294 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
fixed muted status in Sound and SoundManager
b5d3367 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added SoundManager::playCardRemovedSound
515ce38 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added TODO to ShowUnitsDialog
c1119a0 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
made layouts respect navigation bar
19a9902 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added call to OnboardingSupportActivity to MainActivity#onCreate
6de4054 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
fixed reset on faction switch if same faction is selected
ae64bec 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
removed deprecated OldMainActivity, Row and Unit classes (finally)
adc18eb 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation TODOs
38781c5 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to GwentApplication
25ffdcd 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
Merge branch 'dev' into backend-update
05bf408
@PeterNaggschga
added RuleSection.java
025a672 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to RuleActivity
5cd2c25 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
cleaned up SettingsActivity
e654b28 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to SettingsActivity
e4b136e 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added IndicatorManager.java
2f518de 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added string resource for first use preference key
d833a8f 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
cleaned up OnboardingSupportActivity
aa28963 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
renamed OnboardingSupportActivity to IntroductionActivity
035b8fe 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
cleaned up PlaceholderFragment
1ee12eb 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
renamed everything from onboarding support to introduction
c6b2ad6 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to IntroductionActivity
adaa997 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to SectionsPagerAdapter
59a3ad3 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
renamed PlaceholderFragment to IntroductionFragment
28c6a19 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to IntroductionFragment
109ffec 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga PeterNaggschga linked an issue May 31, 2024 that may be closed by this pull request
remove background images #10
Closed
@PeterNaggschga
removed background image description string
17dc736 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to MainActivity
22e26f9 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
added documentation to MainActivity
dcb39ae 
Signed-off-by: PeterNaggschga <rep.akhcsztan@gmail.com>
@PeterNaggschga
Merge remote-tracking branch 'origin/backend_update' into backend-update
8f9247c 
# Conflicts:
#	app/src/main/java/com/peternaggschga/gwent/MainActivity.java
@PeterNaggschga PeterNaggschga marked this pull request as ready for review May 31, 2024 20:37
@PeterNaggschga PeterNaggschga merged commit 6f2d498 into dev May 31, 2024
1 check passed
@PeterNaggschga PeterNaggschga deleted the backend_update branch May 31, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PeterNaggschga PeterNaggschga

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save state using android tools rather than json remove background images
1 participant
@PeterNaggschga