Restart dialogs #85
Merged
Restart dialogs #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wbaccinelli , could you please take a look what I am missing in actions_idle_commands.py to let the state machine figure out whether there is an uncompleted dialog after the user types "verder"? |
wbaccinelli
reviewed
May 12, 2023
Rasa_Bot/actions/helper.py
Outdated
Comment on lines
114
to
116
| UserInterventionState.users_nicedayuid == user_id, | ||
| UserInterventionState.intervention_component_id == intervention_component_id | ||
| ) |
There was a problem hiding this comment.
in the table there is also the completed field that we can check to filter out the results.
Suggested change
| UserInterventionState.users_nicedayuid == user_id, | |
| UserInterventionState.intervention_component_id == intervention_component_id | |
| ) | |
| UserInterventionState.users_nicedayuid == user_id, | |
| UserInterventionState.intervention_component_id == intervention_component_id | |
| UserInterventionState.completed.is_(False) | |
| ) |
|
Moving everythting to the FSM was too complicated, so the actions will check the presence of uncompleted dialog, and the FSM will trigger the right one. In the FMS there is also an additional layer of checking, in case the user types 'verder' (which triggers the rule for continuing the dialog in any case) when this is not allowed. |
wbaccinelli
approved these changes
May 17, 2023
filter for uncompleted dialogs only Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PerfectFit-project/virtual-coach-issues#296 for the goal-setting dialog.