326 video dialogs activation #80
Conversation
There was a problem hiding this comment.
I am not yet very familiar with the whole timing structure part (I hope you can explain at some point), but otherwise it looks good! I think it would just sometimes help to find one's way through the many intents, actions, etc. if the names are a bit consistent. So in your case, for example, always include "video" so it is clear that sth is about a video.
scheduler/requirements.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| celery | |||
| python-dotenv | |||
| git+https://github.com/PerfectFit-project/virtual-coach-db@v0.1.13 | |||
| git+https://github.com/PerfectFit-project/virtual-coach-db@326-video-dialogs-activation | |||
There was a problem hiding this comment.
Remember to change at the end.
There was a problem hiding this comment.
Yes, it's good to keep this in mind
Rasa_Bot/data/nlu.yml
Outdated
| examples: | | ||
| - EXTERNAL_first_aid_kit_video | ||
|
|
||
| - intent: EXTERNAL_trigger_future_self_long |
There was a problem hiding this comment.
I would find it helpful if all of these intents ended with "_video" like the one for the first aid kit to make things easier to recognize.
|
SonarCloud Quality Gate failed. |
Fixes: PerfectFit-project/virtual-coach-issues#326
With this PR, the video dialogs and the preparation dialogs are started using the complete flow (from celery, rescheduling dialog, video presentation dialog).