Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise first aid kit #72

Merged
merged 7 commits into from
Feb 16, 2023
Merged

Revise first aid kit #72

merged 7 commits into from
Feb 16, 2023

Conversation

nelealbers
Copy link
Contributor

Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job! One note: I see two models have been uploaded, can we delete the least recent one?

else:
kit_text += activity.intervention_activity.intervention_activity_title
kit_text += activity.intervention_activity.intervention_activity_title
kit_text += ": " + activity.intervention_activity.intervention_activity_description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intervention_activity_description is always empty currently. Do we have the content for this?

@nelealbers
Copy link
Contributor Author

@wbaccinelli Yes, the resources Milon and Kristell have prepared in teams have a short and a long title. This long title is the description. So far we have not yet incorporated that info in our example activities in the database.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 1 Code Smell

1.4% 1.4% Coverage
0.0% 0.0% Duplication

@nelealbers nelealbers merged commit b7faca5 into main Feb 16, 2023
@nelealbers nelealbers deleted the 318_first_aid_kit branch February 16, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review 1.8 First aid kit
2 participants