Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

313 preparation phase dialog #70

Merged
merged 15 commits into from
Feb 8, 2023
Merged

Conversation

7lopol7
Copy link
Contributor

@7lopol7 7lopol7 commented Jan 25, 2023

Fix PerfectFit-project/virtual-coach-issues#313

Added the preparation phase dialog

@7lopol7 7lopol7 requested a review from wbaccinelli January 25, 2023 10:53
Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I left some comments for making the flow a bit more consistent.
Also, fix the issues suggested by the Python CI before merging

Rasa_Bot/actions/actions_preparation_phase.py Outdated Show resolved Hide resolved
Rasa_Bot/actions/actions_preparation_phase.py Outdated Show resolved Hide resolved
Rasa_Bot/data/rules_preparation_phase.yml Outdated Show resolved Hide resolved
@7lopol7
Copy link
Contributor Author

7lopol7 commented Jan 30, 2023

@wbaccinelli I implemented the changes you suggested, could you take a look at them?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wbaccinelli wbaccinelli merged commit 6b943dc into main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement C1.14 Scheduling preparation phase dialogs
2 participants