288 share and create graphs #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking to see how functionality works, creation of a simple graph. Local changes to rules are not pushed, but include changes to call these actions from somewhere easier than the middle of the dialog
Branch wasnt up to date
Still needs to be cleaned up, the other two figures need to be added, and PA needs to be dealt with
Subplots work, but still not particularly pretty. Neither is the code, yet
Completed show_barchart_difficult situations, now same logic should be implemented in pa, and a way to customize the file path needs to be found
This avoids the filepath being hardcoded so that we can use the upload_file action after every action that needs it
Now gets the correct results from the database
Checkstyle fixes
wbaccinelli
approved these changes
Jan 24, 2023
wbaccinelli
reviewed
Jan 25, 2023
Applying suggestions, but still need to deal with additional feedback Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Wrong indentation
Pull request suggestions considered and code has been revised
Locally prospector was passing so weird for it to fail here
Cant run pytype locally so might have to do this more times
Fixes proposed by Kristell, there are a few more that require functional changes that need to be implemented
Kristell's suggestions to merge lapse and relapse in the graphs
Another of kristells suggestions
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed the issue, created the graphs, fixed the problem with the wrong retrieval from the database, so that part is fine now.
Only thing to note is that I delete the file again in the action "send_metadata" as that is the last place it is used, because I think the only time we will used send_metadata, is when we upload something ourselves and send it. If this is not the case, then the deletion needs to be in a separate action.
Fixes: PerfectFit-project/virtual-coach-issues#288