-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
304 watching video #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left just some suggestions
|
||
async def run(self, dispatcher, tracker, domain): | ||
user_id = int(tracker.current_state()['sender_id']) # retrieve userID | ||
new_intent = 'EXTERNAL_done_with_video' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can also be moved to the definitions in the DB
if last_utterance != 'utter_ask_video_clear_option': | ||
return {"video_clear_option": None} | ||
|
||
video_clear = self._validate_video_clear_response(value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will need to change this to use the validator
examples: | | ||
- "EXTERNAL_done_with_video" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
SonarCloud Quality Gate failed. |
Added the video watching dialog
Fix: PerfectFit-project/virtual-coach-issues#304