Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

304 watching video #65

Merged
merged 17 commits into from
Jan 13, 2023
Merged

304 watching video #65

merged 17 commits into from
Jan 13, 2023

Conversation

7lopol7
Copy link
Contributor

@7lopol7 7lopol7 commented Jan 11, 2023

Added the video watching dialog
Fix: PerfectFit-project/virtual-coach-issues#304

@7lopol7 7lopol7 requested a review from wbaccinelli January 11, 2023 13:46
Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left just some suggestions

Rasa_Bot/actions/actions_watching_a_video.py Outdated Show resolved Hide resolved

async def run(self, dispatcher, tracker, domain):
user_id = int(tracker.current_state()['sender_id']) # retrieve userID
new_intent = 'EXTERNAL_done_with_video'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can also be moved to the definitions in the DB

Rasa_Bot/actions/actions_watching_a_video.py Outdated Show resolved Hide resolved
if last_utterance != 'utter_ask_video_clear_option':
return {"video_clear_option": None}

video_clear = self._validate_video_clear_response(value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need to change this to use the validator

examples: |
- "EXTERNAL_done_with_video"


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Rasa_Bot/data/rules_watching_a_video.yml Outdated Show resolved Hide resolved
Rasa_Bot/data/rules_watching_a_video.yml Outdated Show resolved Hide resolved
7lopol7 and others added 8 commits January 11, 2023 19:51
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
Co-authored-by: Walter Baccinelli <100706999+wbaccinelli@users.noreply.github.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wbaccinelli wbaccinelli merged commit bf239e5 into main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement 1.12 Meta-dialog watch this video
2 participants