-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
290 general activity #61
Conversation
# Conflicts: # Rasa_Bot/actions/helper.py # Rasa_Bot/data/nlu.yml # Rasa_Bot/models/20221014-151911-hot-dodecagon.tar.gz
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK this looks good to me, although I'm not so familiar with the Rasa dialogs so I can't review in depth. It looks like a huge amount has been added here. Some of the yaml files are getting quite large so I suppose it is tricky to keep track when adding more content? (I haven't tried this myself, so maybe it's easy enough).
I was intrigued by the mysterious "ordered-chateau" file
- action: utter_general_activity_choose_next_activity | ||
- action: general_activity_next_activity_form | ||
- active_loop: general_activity_next_activity_form | ||
- active_loop: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my own ignorance but what is the purpose of the active_loop: null
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The active_loop: null
is required by the syntax in Rasa in order to close the forms. Rasa...
Yes, the content is becoming really huge. We are using different files for each conversation, to contain the complexity, but it will be tricky still. The "ordered-chateau" is the rasa trained mode. The names are randomly assigned and are very funny. |
Fixes: PerfectFit-project/virtual-coach-issues#290
The general activity dialog has been implemented in this PR.