Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

290 general activity #61

Merged
merged 40 commits into from
Nov 29, 2022
Merged

290 general activity #61

merged 40 commits into from
Nov 29, 2022

Conversation

wbaccinelli
Copy link
Contributor

Fixes: PerfectFit-project/virtual-coach-issues#290

The general activity dialog has been implemented in this PR.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.4% 0.4% Coverage
0.0% 0.0% Duplication

@raar1 raar1 self-requested a review November 29, 2022 08:19
Copy link
Contributor

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK this looks good to me, although I'm not so familiar with the Rasa dialogs so I can't review in depth. It looks like a huge amount has been added here. Some of the yaml files are getting quite large so I suppose it is tricky to keep track when adding more content? (I haven't tried this myself, so maybe it's easy enough).

I was intrigued by the mysterious "ordered-chateau" file

- action: utter_general_activity_choose_next_activity
- action: general_activity_next_activity_form
- active_loop: general_activity_next_activity_form
- active_loop: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my own ignorance but what is the purpose of the active_loop: null ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The active_loop: null is required by the syntax in Rasa in order to close the forms. Rasa...

@wbaccinelli
Copy link
Contributor Author

Yes, the content is becoming really huge. We are using different files for each conversation, to contain the complexity, but it will be tricky still.

The "ordered-chateau" is the rasa trained mode. The names are randomly assigned and are very funny.

@wbaccinelli wbaccinelli merged commit 900e679 into main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement General Activity Dialog
3 participants