get five highest rated activities #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raar1
approved these changes
Nov 15, 2022
| @@ -34,7 +34,10 @@ async def run(self, dispatcher, tracker, domain): | |||
|
|
|||
| kit_exists = True | |||
|
|
|||
| for activity_idx, activity in enumerate(selected): | |||
| # get up to the first 5 highest rated activities | |||
| sorted_activities = sorted(selected, key=lambda x: x.activity_rating)[:5] | |||
There was a problem hiding this comment.
Is this 5 just for test purposes, or will it always be the top 5? I still think there should be a NUM_TOP_ACTIVITIES var or something
There was a problem hiding this comment.
It will always be the top 5, but it's way better to have this as a variable
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the rasa_action to retrieve the first aid kit, in order to get only the 5 activities with the highest rating