Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central #58

Merged
merged 19 commits into from
Sep 23, 2022
Merged

Central #58

merged 19 commits into from
Sep 23, 2022

Conversation

nelealbers
Copy link
Contributor

@nelealbers nelealbers commented Sep 15, 2022

Fixes PerfectFit-project/virtual-coach-issues#266.

Changes:

  • rule to detect "urgent" intent at start of conversation and then send a message for people to contact a human (need to refine what this message is)
  • when we get a message with low nlu confidence at start of conversation, we present the central mode menu.

@nelealbers
Copy link
Contributor Author

@wbaccinelli From what I can see, the failed Python CI test has nothing to do with what I have done. For the Rasa CI, does it fail because we have now split up the files?

@wbaccinelli
Copy link
Contributor

@nelealbers I will take a look at the python CI issues. The Rasa CI has been already fixed here to take into account the file splitting. The log says that the intents 'urgent' and 'CENTRAL_get_first_aid_kit' are not part of the domain. Can you check this?

@nelealbers
Copy link
Contributor Author

@wbaccinelli Thanks, fixed!

Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. We need the content to be fully defined, to test that everything is working properly


# Only applies at start of conversation
- rule: Process when people talk about urgent things that we cannot handle
conversation_start: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice solution to avoid this to be triggered during the dialogs, but the action_end_dialog does not start a new conversation, but resets the slots through the default action_restart. So, also the action_end_dialog should be modified to make it start a new conversation maybe using also action_session_start.
Another possible solution would be to use a rule with condition that checks that the current_intervention_component slot is not set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbaccinelli Ah good point. I will adapt the action_end_dialog action.

Comment on lines +15 to +18
- intent: urgent
- action: utter_refer
- action: utter_central_mode_options
- action: action_end_dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this, but the confidence level of confidence is too low (even if I write precisely one of the examples). I think we have to pay a lot of attention on how we train the model. Maybe we should have different intents for different words?

@nelealbers
Copy link
Contributor Author

nelealbers commented Sep 19, 2022

@wbaccinelli I now got things to work. There was a bug that sometimes made things break that was fixed in 3.2.8: https://rasa.com/docs/rasa/changelog. So I moved everything to 3.2.8.

As to the rasa restart vs. new conversation start, the restart removes all slots and conversation history, while the new conversation start only removes the conversation history (i.e., not the slots). I think it is the restart behavior that we want or not?

Let me know if I should merge this now.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

FROM rasa/rasa-sdk:3.1.1
FROM rasa/rasa-sdk:3.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM rasa/rasa-sdk:3.1.1
FROM rasa/rasa-sdk:3.2.1
FROM rasa/rasa-sdk:3.2.8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelealbers I think this needs to be changed, but everything is working now! Nice work!

Copy link
Contributor Author

@nelealbers nelealbers Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbaccinelli I thought so at first too, but it seems that rasa-sdk has different non-matching version numbers: https://rasa.com/docs/action-server/rasa-sdk-changelog/. Their newest version is 3.2.1 according to their changelog.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelealbers ok, perfect! I will merge the branch then.

@wbaccinelli wbaccinelli merged commit a53d4a7 into main Sep 23, 2022
@nelealbers nelealbers deleted the central branch December 12, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement 'central mode'
2 participants