Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing User Preferences in DB #57

Merged
merged 15 commits into from
Oct 5, 2022

Conversation

BendikC
Copy link
Contributor

@BendikC BendikC commented Sep 13, 2022

Added functionality to trigger a form by typing in 'user preferences'. The form will ask for the users preferences and validate each input, and will subsequently store the preferences in the database.
In order to test this functionality the .env file in the main repo needs to be changed so that the TEST_USER_ID is the ID of the device that is being tested from.

Bendikchristensen and others added 15 commits September 7, 2022 09:28
…to whether or not the actions part works as I need to find a way to run the actions separately while doing rasa shell, but the form is triggered so that is some progress.
Doesnt allow the slots to be instantly filled so they should trigger one at a time
Slot conditions so that each slot can only be filled when it is being requested
Stuck in an infinite loop requesting a valid format and rejecting the format because of wrongful if statement. Added some logging and reversed the if statement to see if it works this time around
Pushing main user preferences to db code for manual testing, should work the same as the dialog answers as it is modelled by it.
An additional part in rasa also needed to be added in order to actually call the action for it to execute.
Converting string to timestamp, hardcoding the test user id to be able to establish a connection to the database
Can now insert user preferences into DB, to test this you need to configure your test user id in the perfectfit main .env file to be your own id
Logs for debugging removed
…ecution-preferences-in-db

Simple pull into my own branch
Hopefully the final one, pylint is being quite annoying about the tracker and domain even though they are required
Fixed some code smells, hopefully now all the checks pass
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

3.6% 3.6% Coverage
0.0% 0.0% Duplication

@BendikC BendikC requested a review from wbaccinelli September 28, 2022 12:01
Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! We should find a better way to input the time. a good way could be letting the user choose the part of the day (morning, afternoon, evening) as for the rescheduling of the future self. This can be an improvement to be included in a self-standing issue.

I just have a question: how did you generate the story_graph.dot file? This can be useful

@wbaccinelli wbaccinelli merged commit d4833f1 into main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants