Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed video waiting time #148

Merged
merged 4 commits into from
Aug 4, 2023
Merged

fixed video waiting time #148

merged 4 commits into from
Aug 4, 2023

Conversation

wbaccinelli
Copy link
Contributor

@wbaccinelli wbaccinelli requested a review from bscheltinga August 4, 2023 08:39
Copy link
Contributor

@bscheltinga bscheltinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

except Exception:
duration = 30
# 1 minute waiting time after the video link is sent
duration = 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this as constant to e.g. virtual_coach_db.helper.definitions. Also, if people already watched a video, isn't 60 seconds then too long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point. The pause length was decided by Eline

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@wbaccinelli wbaccinelli merged commit 97dff13 into main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the waiting time of videos
2 participants