396 hrs autocomplete on expire #140

wbaccinelli · 2023-08-01T14:36:26Z

Fixes: PerfectFit-project/virtual-coach-issues#396
Fixes: PerfectFit-project/testing-tickets#25
Fixes: PerfectFit-project/virtual-coach-issues#393
Fixes: PerfectFit-project/testing-tickets#26

Storing the branch chosen by the user in the relapse dialog as a new closed answer
Moved the expiration case management from the celery_tsks to the single state for clarity
Improved intents management in ehbo
In the relapse state, the dialog is auto-completed in case a user-initiated relapse dialog expires, out of the relapse branch

nelealbers

Looks good, just added two thoughts/comments.

nelealbers · 2023-08-02T11:36:24Z

scheduler/state_machine/state_machine_utils.py

+
+    # if there are no answers or the answer came before the last execution of the dialog,
+    # return None
+    if last_answer is None or last_answer.datetime < last_execution.last_time:


So the last_time value is always only set when a dialog is completed, not yet when it is started?

last_time is updated when the dialog is started, this is why if the answer came before that, it is for sure from another run

Ah I seee, that makes sense!

nelealbers · 2023-08-02T11:39:14Z

scheduler/state_machine/controller.py

+            self.set_new_state(ExecutionRunState(self.user_id))
+
+        else:
+            next_day = datetime.now() + timedelta(days=1)


I was wondering if adding one day is a good idea, since there might be a structural reason why people did not complete the dialog now. For example, could we just use people's preferred time from the profile creation dialog for this? But I suppose especially at the start people might not yet have such a preferred time. And maybe this is just overcomplicating things.