Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403 remove hrs preparation #136

Merged
merged 7 commits into from
Jul 31, 2023
Merged

403 remove hrs preparation #136

merged 7 commits into from
Jul 31, 2023

Conversation

wbaccinelli
Copy link
Contributor

Fixes: PerfectFit-project/virtual-coach-issues#403
Fixes: PerfectFit-project/virtual-coach-issues#400

Changed the menu selection. Now the options are split in separate utterances, and the ones that are not always available are checked before showing them. As a safety layer, this is first done in the rasa actions and then in the state machine.

The relapse dialog is no more available before the execution phase.

The order of the menu utterance has been modified, and the default first utterance has been adapted.

@wbaccinelli wbaccinelli requested a review from nelealbers July 28, 2023 07:04
Copy link
Contributor

@nelealbers nelealbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just added a few small comments.

Rasa_Bot/domain/domain_common.yml Outdated Show resolved Hide resolved
Rasa_Bot/domain/domain_common.yml Outdated Show resolved Hide resolved
Rasa_Bot/domain/domain_idle_commands.yml Outdated Show resolved Hide resolved
scheduler/state_machine/controller.py Outdated Show resolved Hide resolved
scheduler/state_machine/controller.py Show resolved Hide resolved
scheduler/state_machine/controller.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable HRS dialog during preparation phase "Sorry ik begrijp het niet" menu
2 participants