Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

390 pause after profile creation #132

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

wbaccinelli
Copy link
Contributor

@wbaccinelli wbaccinelli commented Jul 20, 2023

Fixes: PerfectFit-project/virtual-coach-issues#390
Fixes: PerfectFit-project/testing-tickets#19

After the completion of the profile creation dialog, the conversation is now paused for 30 seconds before triggering the next dialog. The pause is necessary for two reasons:

  • we cannot triggered immediately the next dialog, because the messages of the profile will be dispatched also during the new dialog (due to the time delay used between the messages)
  • if the user types something during between the two dialogs, mixed messages will be received

@wbaccinelli wbaccinelli requested a review from nelealbers July 20, 2023 14:47
Copy link
Contributor

@nelealbers nelealbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just added a comment to help people like me understand what it means to "acknowledge" the FSM.

"""
This task sends a pause the dialog and schedules the resume.
Args:
user_id: the ID of the user to send the trigger to
trigger: the intent to be sent
time: time for scheduling the dialog resume
acknowledge: if true, use the trigger_intervention_component task, to acknowledge the FSM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean to acknowledge the FSM? Maybe this is standard terminology but for sb like me, it would help if you could add in parentheses what that means.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing "doei" at end of profile creation dialog messes up messages received End of profile creation dialog
2 participants