Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed celery task in the actions #131

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

wbaccinelli
Copy link
Contributor

@wbaccinelli wbaccinelli commented Jul 20, 2023

Fixes: PerfectFit-project/virtual-coach-issues#388
Fixes: PerfectFit-project/virtual-coach-issues#391
Fixes: PerfectFit-project/testing-tickets#22
Fixes: PerfectFit-project/testing-tickets#23

The problem was that the type of task that was sent to the scheduler by the video dialogs was wrong. What happened was that the just the generic watch_video_dialog and reschedule_preparation_phase dialogs where stored in the FSM. If the dialog expired, and the FSM rescheduled it, the wrong element was saved in the DB, and it was never marked as completed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wbaccinelli wbaccinelli requested a review from nelealbers July 20, 2023 14:47
Copy link
Contributor

@nelealbers nelealbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wbaccinelli wbaccinelli merged commit 81968a8 into main Jul 21, 2023
wbaccinelli added a commit that referenced this pull request Jul 24, 2023
…ed-video-dialog"

This reverts commit 81968a8, reversing
changes made to 7e127cd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants