Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

363 fix closing dialog #103

Merged
merged 3 commits into from
Jun 16, 2023
Merged

363 fix closing dialog #103

merged 3 commits into from
Jun 16, 2023

Conversation

bscheltinga
Copy link
Contributor

@bscheltinga bscheltinga requested a review from wbaccinelli June 16, 2023 08:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

wbaccinelli
wbaccinelli approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! XD

@bscheltinga bscheltinga merged commit 2194271 into main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbaccinelli wbaccinelli wbaccinelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C1.20 Closing dialog check behavior C1.20 closing dialogue
2 participants
@bscheltinga @wbaccinelli