adjusted speed to message length #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raar1
approved these changes
Jun 16, 2023
| @@ -13,6 +14,11 @@ | |||
|
|
|||
|
|
|||
| NICEDAY_API_URL = os.getenv('NICEDAY_API_ENDPOINT') | |||
| # proportional factor between the number of words in a message and the time to wait before the | |||
| # newt message is delivered | |||
| WORDS_PER_SECOND = 5 | |||
There was a problem hiding this comment.
Haha, ok, so this is the fix for the PF app spamming users with 6000 messages a minute like a deranged stalker?
There was a problem hiding this comment.
ahahah yes, now it should be less annoying (if possible).
| # newt message is delivered | ||
| WORDS_PER_SECOND = 5 | ||
| # maximum delay between a message and the next one | ||
| MAX_DELAY = 10 |
There was a problem hiding this comment.
Also units of seconds, I assume?
There was a problem hiding this comment.
yep, I'm updating the definition
Co-authored-by: Robin Richardson <raar1@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: PerfectFit-project/virtual-coach-issues#360
Fixes: PerfectFit-project/testing-tickets#3
The messages sending thorough the API happens when the dialogs are externally triggered. The response is sent to the API through the
custom_channels.py. A delay between one message and the other has been added there.