Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

362 fix general activity #101

Merged
merged 5 commits into from
Jun 26, 2023
Merged

362 fix general activity #101

merged 5 commits into from
Jun 26, 2023

Conversation

wbaccinelli
Copy link
Contributor

@wbaccinelli wbaccinelli requested a review from nelealbers June 13, 2023 10:04
@wbaccinelli wbaccinelli requested a review from bscheltinga June 16, 2023 09:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

bscheltinga
bscheltinga approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@bscheltinga bscheltinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

nelealbers
nelealbers approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@nelealbers nelealbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the whole dialog as well and it works :).

Rasa_Bot/actions/helper.py
@@ -162,6 +162,8 @@ def get_last_completed_dialog_part_from_db(user_id: int,
)

if selected is not None:
if selected.last_part == 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well noticed!

@wbaccinelli wbaccinelli merged commit 98a6240 into main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bscheltinga bscheltinga bscheltinga approved these changes

@nelealbers nelealbers nelealbers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C1.16 General activity check bug C1.16 general activity dialogue
3 participants
@wbaccinelli @nelealbers @bscheltinga