Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

383 messages optimization #19

Merged
merged 3 commits into from
Jul 14, 2023
Merged

383 messages optimization #19

merged 3 commits into from
Jul 14, 2023

Conversation

wbaccinelli
Copy link
Contributor

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wbaccinelli wbaccinelli requested a review from raar1 July 14, 2023 08:27
Copy link
Contributor

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work man! I hadn't realised there was also some delay in the authentication stuff happening here

@@ -31,11 +37,37 @@ const options = {
const expressAppConfig = oas3Tools.expressAppConfig(path.join(__dirname, 'api/openapi.yaml'), options);
const app = expressAppConfig.getApp();

function setupChat(therapistId, token) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... so, all this setup only needs to be done once (per session/token?). Before was it doing all this authentication stuff every time it sent a message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, isn't this great?

@wbaccinelli wbaccinelli merged commit 0bd41ec into main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessagesService in niceday_api not working properly
2 participants