Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed dependant on length #17

Merged
merged 2 commits into from
Jun 16, 2023
Merged

speed dependant on length #17

merged 2 commits into from
Jun 16, 2023

Conversation

wbaccinelli
Copy link
Contributor

Fixes: PerfectFit-project/virtual-coach-issues#360

The delay in the broker has been changed to be adapted to the previous message length.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

@wbaccinelli wbaccinelli requested a review from raar1 June 14, 2023 14:50
raar1
raar1 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delay (set by words per second) is implemented here as well as in the Rasa actions (I think, from another PR). Why does it need to be implemented in both places?

niceday-broker/index.js
sendMessage(message.text, parseInt(message.recipient_id, 10), attachment);
});

if (ENVIRONMENT === 'prod') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're not testing this in dev mode currently? Or is all testing happening through prod?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local testing is in dev mode, but the deployed version is in prod mode, to resemble the actual behavior

@wbaccinelli
Copy link
Contributor Author

The delay (set by words per second) is implemented here as well as in the Rasa actions (I think, from another PR). Why does it need to be implemented in both places?

Because our infrastructure is way too complicated, so there are two ways the messages are exchanged with NiceDay:

  • The broker, which intervenes when the messages are generated during the conversation, in the Rasa stories
  • The custom_channels of Rasa, that we need for running the external triggers and that uses the niceday_api.

So we need to change this stuff in both the places

@wbaccinelli wbaccinelli merged commit 5ac7d8c into main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raar1 raar1 raar1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust messages speed
2 participants
@wbaccinelli @raar1