Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing disconnected broker #16

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Fixing disconnected broker #16

merged 5 commits into from
Jun 6, 2023

Conversation

wbaccinelli
Copy link
Contributor

@wbaccinelli wbaccinelli requested a review from raar1 June 5, 2023 14:38
raar1
raar1 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only question would be, are messages that failed to be sent eventually resent? Like, if a message does not send because the broker was disconnected, will it be resent later, or does it just not happen?

@wbaccinelli
Copy link
Contributor Author

Looks good. My only question would be, are messages that failed to be sent eventually resent? Like, if a message does not send because the broker was disconnected, will it be resent later, or does it just not happen?

Good point. No the messages are not resent. I can make the broker try again, but a proper management of this would require probably something more complex like a queuing system.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wbaccinelli wbaccinelli merged commit f42b5d6 into main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raar1 raar1 raar1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broker disconnects from the chat service
2 participants
@wbaccinelli @raar1