48 adding fmcw nodes to existing develop branch being required #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 13, 2024 17:18
Signed-off-by: TimoHinsemann <timo.hinsemann@persival.de>
…apping nodes not regarded yet, redundancy of nodes possible for now). Also tags are added for each FMCW-Node. Signed-off-by: TimoHinsemann <timo.hinsemann@persival.de>
ClemensLinnhoff
requested changes
Jan 7, 2025
ClemensLinnhoff
approved these changes
Jan 28, 2025
ClemensLinnhoff
added a commit
that referenced
this pull request
Feb 3, 2025
* Empty tag-spaces added * Tags added for every node * Irrelevant space change * Update src submodule Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de> * 48 adding fmcw nodes to existing develop branch being required (#49) * Added new src to branch Signed-off-by: TimoHinsemann <timo.hinsemann@persival.de> * Adding FMCW-Nodes to develop-branch as seperate tree-structure (overlapping nodes not regarded yet, redundancy of nodes possible for now). Also tags are added for each FMCW-Node. Signed-off-by: TimoHinsemann <timo.hinsemann@persival.de> * Fusion of FMCW-branch and develop-branch. * Unnecessary line breaks removed. * IDs changed to be consecutive and empty lines removed. * Source directory change. --------- Signed-off-by: TimoHinsemann <timo.hinsemann@persival.de> Co-authored-by: TimoHinsemann <timo.hinsemann@persival.de> * Source directory changed. * Source directory changed to newest. * Tags for 'detection state error' added. * Tags for 'detection state error' refined. * Source directory changed to newest. --------- Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de> Signed-off-by: TimoHinsemann <timo.hinsemann@persival.de> Co-authored-by: Christoph Popp <147421952+ChristophPopp@users.noreply.github.com> Co-authored-by: ClemensLinnhoff <clemens.linnhoff@persival.de> Co-authored-by: TimoHinsemann <timo.hinsemann@persival.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36 , #42 , #45 and #48.
Changes are already discussed with @ChristophPopp - Merging to develop-branch seems right for now. (?)