-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding parentIds for motion scan effect #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment in the corresponding issue. I do not see the motion scan effect producing false positives or false negatives. The detections are all valid, just at a different position than expected.
I just inserted the detection state error node for this. |
@TimoHinsemann as this PR inserts several parentIDs, I guess I also need to provide references for each of these new connections, right? |
What about this PR @TimoHinsemann? Is it out-dated and can be closed? |
Hey @ClemensLinnhoff, yes, with the last update of the develop-branch, the issues #36, #42, #45 and #48 should be solved. So this PR here can be closed. A double-check from your side - to be on the safe side - would be maybe useful. After that, we should merge the develop-branch into the main-branch. I will create a PR for that now. @PhRosenberger I am very sorry for not reaching out after your last comment here, not only the thesis was stealing my time but also I missed to change my Notification-Mail-Adress to the company adress. I hope the new commits are in your interest! |
As written in #45, the motion scan effect node is currently flying around besides the tree.
This PR should solve it.