Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where unexpected queuing occurs in qml.ctrl among other functions #6474

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Fix bug where unexpected queuing occurs in qml.ctrl among other functions #6474

merged 8 commits into from
Oct 31, 2024

Conversation

KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Oct 29, 2024 •
edited
Loading

This PR is a copy of this other one pointing to v0.39.0-rc0

[sc-73690]

@github-actions GitHub Actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v0.39.0-rc0@d5d3c2b). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff               @@
##             v0.39.0-rc0    #6474   +/-   ##
==============================================
  Coverage               ?   99.38%           
==============================================
  Files                  ?      452           
  Lines                  ?    42823           
  Branches               ?        0           
==============================================
  Hits                   ?    42561           
  Misses                 ?      262           
  Partials               ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetpuntoG KetpuntoG requested a review from astralcai October 29, 2024 19:20
KetpuntoG and others added 2 commits October 29, 2024 17:12
@KetpuntoG
remove qnodes
83efd58
@KetpuntoG @astralcai
Update doc/releases/changelog-0.39.0.md
45db9b3 
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
@KetpuntoG KetpuntoG requested a review from astralcai October 29, 2024 21:37
astralcai
astralcai approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KetpuntoG KetpuntoG requested a review from albi3ro October 30, 2024 13:26
@mudit2812 mudit2812 added this to the v0.39 milestone Oct 30, 2024
@KetpuntoG KetpuntoG requested a review from mudit2812 October 31, 2024 12:48
@KetpuntoG KetpuntoG merged commit b851ce3 into v0.39.0-rc0 Oct 31, 2024
37 checks passed
@KetpuntoG KetpuntoG deleted the fix-bug-qsvt branch October 31, 2024 20:48
@KetpuntoG KetpuntoG mentioned this pull request Nov 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astralcai astralcai astralcai approved these changes

@mudit2812 mudit2812 mudit2812 approved these changes

@albi3ro albi3ro Awaiting requested review from albi3ro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.39
Development

Successfully merging this pull request may close these issues.
3 participants
@KetpuntoG @mudit2812 @astralcai