Pass keyword arguments of MomentumQNGOptimizer to base class; Fix QNGOptimizer update with singular metric tensor
#6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.39.0-rc0 #6471 +/- ##
==============================================
Coverage ? 99.38%
==============================================
Files ? 452
Lines ? 42797
Branches ? 0
==============================================
Hits ? 42535
Misses ? 262
Partials ? 0 ☔ View full report in Codecov by Sentry. |
PietropaoloFrisoni
approved these changes
Oct 29, 2024
dwierichs
approved these changes
Oct 30, 2024
MomentumQNGOptimizer to base class; Fix QNGOptimizer update with singular metric tensor
Thank you so much! @dwierichs |
|
I can take a look if it's more like a linalg related issue |
|
In qml.optimize.qnspsa there's a similar usage of |
JerryChen97
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The newly added
MomentumQNGOptimizerin #6240 does not use the keyword argumentsapproxandlam.Description of the Change:
Pass the unused arguments to
super().__init__Possible Drawbacks:
No tests are added for this, but these two parameters are inherited from the base class, and they are never tested in the existing test module for the base class to begin with.