fix the math module for autoray 0.7.0 #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Oct 22, 2024
mudit2812
reviewed
Oct 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6429 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 447 447
Lines 42429 42441 +12
=======================================
+ Hits 42169 42181 +12
Misses 260 260 ☔ View full report in Codecov by Sentry. |
|
[sc-76593] |
mudit2812
approved these changes
Oct 22, 2024
dwierichs
approved these changes
Oct 23, 2024
PietropaoloFrisoni
approved these changes
Oct 23, 2024
mudit2812
pushed a commit
that referenced
this pull request
Nov 11, 2024
**Context:** Autoray has released a new version. This has caused failures with several tensorflow functions. **Description of the Change:** Patches tensorflow functions that are now longer working. `null.qubit` no longer returns interface numbers unless we have `gradient_method="backprop"`. This is necessary because null qubit was creating tensorflow arrays with the wrong precision. A device does not need to return interface data in any situation other than backprop. That conversion to the interface data type was unnecessary. **Benefits:** No more autoray version pinning. **Possible Drawbacks:** **Related GitHub Issues:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Autoray has released a new version. This has caused failures with several tensorflow functions.
Description of the Change:
Patches tensorflow functions that are now longer working.
null.qubitno longer returns interface numbers unless we havegradient_method="backprop". This is necessary because null qubit was creating tensorflow arrays with the wrong precision. A device does not need to return interface data in any situation other than backprop. That conversion to the interface data type was unnecessary.Benefits:
No more autoray version pinning.
Possible Drawbacks:
Related GitHub Issues: