-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to skip drawing wire labels #6410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's show_wire_labels
for tape_text
but label_options
for tape_mpl
?
Yeah I don't love that. To me, it feels canonical to embed this new option in the I tried adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6410 +/- ##
==========================================
- Coverage 99.70% 99.38% -0.32%
==========================================
Files 447 447
Lines 42424 42434 +10
==========================================
- Hits 42299 42174 -125
- Misses 125 260 +135 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Christina Lee <christina@xanadu.ai>
**Context:** Wire labels are drawn by default. **Description of the Change:** This PR adds an option to hide the wire labels, which can be useful to produce more clean images, for example. **Benefits:** A convenient feature. **Possible Drawbacks:** More options, I suppose. **Related GitHub Issues:** --------- Co-authored-by: Christina Lee <christina@xanadu.ai>
Context:
Wire labels are drawn by default.
Description of the Change:
This PR adds an option to hide the wire labels, which can be useful to produce more clean images, for example.
Benefits:
A convenient feature.
Possible Drawbacks:
More options, I suppose.
Related GitHub Issues: