Handle recursion errors in CompositeOp methods #6375
Merged
+140
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
reviewed
Oct 10, 2024
astralcai
commented
Oct 10, 2024
albi3ro
reviewed
Oct 10, 2024
albi3ro
reviewed
Oct 10, 2024
mudit2812
reviewed
Oct 10, 2024
astralcai
commented
Oct 10, 2024
astralcai
commented
Oct 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6375 +/- ##
==========================================
- Coverage 99.71% 99.39% -0.32%
==========================================
Files 447 447
Lines 42365 42422 +57
==========================================
- Hits 42244 42167 -77
- Misses 121 255 +134 ☔ View full report in Codecov by Sentry. |
mudit2812
approved these changes
Oct 11, 2024
…o composite-op-recursion
albi3ro
approved these changes
Oct 11, 2024
That was actually the first thing I tried, overriding the |
austingmhuang
pushed a commit
that referenced
this pull request
Oct 23, 2024
By default, `qml.sum` and `qml.prod` set `lazy=True`, which keeps its operands nested. Given the recursive nature of such structures, if there are too many levels of nesting, a `RecursionError` would occur when accessing many of the properties and methods. Catching these errors and re-raising a more sensible error message suggesting that the user could either set `lazy=False` or use the `+` and `@` operators instead, which sets `lazy=False`. **Update** Extending the behaviour to `SProd` Fixes #5948 [sc-67745]
mudit2812
pushed a commit
that referenced
this pull request
Nov 11, 2024
By default, `qml.sum` and `qml.prod` set `lazy=True`, which keeps its operands nested. Given the recursive nature of such structures, if there are too many levels of nesting, a `RecursionError` would occur when accessing many of the properties and methods. Catching these errors and re-raising a more sensible error message suggesting that the user could either set `lazy=False` or use the `+` and `@` operators instead, which sets `lazy=False`. **Update** Extending the behaviour to `SProd` Fixes #5948 [sc-67745]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
qml.sumandqml.prodsetlazy=True, which keeps its operands nested. Given the recursive nature of such structures, if there are too many levels of nesting, aRecursionErrorwould occur when accessing many of the properties and methods. Catching these errors and re-raising a more sensible error message suggesting that the user could either setlazy=Falseor use the+and@operators instead, which setslazy=False.Update
Extending the behaviour to
SProdFixes #5948
[sc-67745]