Remove AllWires validation and associated tests
#6373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllWires validation and associated testsAllWires validation and associated tests
AllWires validation and associated testsAllWires validation and associated tests
AllWires validation and associated testsAllWires validation and associated tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6373 +/- ##
==========================================
- Coverage 99.40% 99.39% -0.01%
==========================================
Files 446 446
Lines 42366 42362 -4
==========================================
- Hits 42112 42107 -5
- Misses 254 255 +1 ☔ View full report in Codecov by Sentry. |
austingmhuang
pushed a commit
that referenced
this pull request
Oct 23, 2024
**Context:** Pennylane checks every operator in the initial tape such that if `op.num_wires == AllWires and op.wires and device.wires`, then `op.wires == device.wires`. This is an edge case that kinda only applies to GlobalPhase. And it really is fine if GlobalPhase has wires that are only part of the device wires. We kinda ignore global phase wires anyway. **Description of the Change:** Removes code block for validation and accompanying tests. **Benefits:** Prevents future performance issues and deals with `GlobalPhase` edge case. **Possible Drawbacks:** None [sc-72066]
mudit2812
pushed a commit
that referenced
this pull request
Nov 11, 2024
**Context:** Pennylane checks every operator in the initial tape such that if `op.num_wires == AllWires and op.wires and device.wires`, then `op.wires == device.wires`. This is an edge case that kinda only applies to GlobalPhase. And it really is fine if GlobalPhase has wires that are only part of the device wires. We kinda ignore global phase wires anyway. **Description of the Change:** Removes code block for validation and accompanying tests. **Benefits:** Prevents future performance issues and deals with `GlobalPhase` edge case. **Possible Drawbacks:** None [sc-72066]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Pennylane checks every operator in the initial tape such that if
op.num_wires == AllWires and op.wires and device.wires, thenop.wires == device.wires.This is an edge case that kinda only applies to GlobalPhase. And it really is fine if GlobalPhase has wires that are only part of the device wires. We kinda ignore global phase wires anyway.
Description of the Change:
Removes code block for validation and accompanying tests.
Benefits: Prevents future performance issues and deals with
GlobalPhaseedge case.Possible Drawbacks: None
[sc-72066]