Add preliminary support for qml.labs module sandboxing
#6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlxd
commented
Oct 9, 2024
|
[sc-75512] |
mlxd
commented
Oct 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6369 +/- ##
==========================================
- Coverage 99.40% 99.39% -0.01%
==========================================
Files 446 447 +1
Lines 42366 42365 -1
==========================================
- Hits 42112 42109 -3
- Misses 254 256 +2 ☔ View full report in Codecov by Sentry. |
mlxd
commented
Oct 9, 2024
mlxd
commented
Oct 9, 2024
rashidnhm
reviewed
Oct 10, 2024
mudit2812
reviewed
Oct 10, 2024
Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com>
Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com>
Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
approved these changes
Oct 10, 2024
rashidnhm
approved these changes
Oct 10, 2024
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
austingmhuang
pushed a commit
that referenced
this pull request
Oct 23, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
test directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
- [x] The PennyLane source code conforms to
[PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
To lint modified files, simply `pip install pylint`, and then
run `pylint pennylane/path/to/file.py`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:** This PR adds `tach` as a development dependency to ensure
`qml.labs` additions do not migrate into mainline PennyLane.
**Description of the Change:** Configs are added to restrict this
library wide, with pre-commit hook support added to prevent additions
going upstream.
**Benefits:** Prevents `qml.labs` additions entering into the main
PennyLane library.
**Possible Drawbacks:** Currently requires explicit use of pre-commit
hooks. CI settings and partitioning to follow.
**Related GitHub Issues:**
---------
Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
added a commit
that referenced
this pull request
Nov 11, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
test directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
- [x] The PennyLane source code conforms to
[PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
To lint modified files, simply `pip install pylint`, and then
run `pylint pennylane/path/to/file.py`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:** This PR adds `tach` as a development dependency to ensure
`qml.labs` additions do not migrate into mainline PennyLane.
**Description of the Change:** Configs are added to restrict this
library wide, with pre-commit hook support added to prevent additions
going upstream.
**Benefits:** Prevents `qml.labs` additions entering into the main
PennyLane library.
**Possible Drawbacks:** Currently requires explicit use of pre-commit
hooks. CI settings and partitioning to follow.
**Related GitHub Issues:**
---------
Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR adds
tachas a development dependency to ensureqml.labsadditions do not migrate into mainline PennyLane.Description of the Change: Configs are added to restrict this library wide, with pre-commit hook support added to prevent additions going upstream.
Benefits: Prevents
qml.labsadditions entering into the main PennyLane library.Possible Drawbacks: Currently requires explicit use of pre-commit hooks. CI settings and partitioning to follow.
Related GitHub Issues: