sample_probs is extracted out of sample_state
#6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nylane into all_mp-processDM
mudit2812
requested changes
Oct 10, 2024
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
JerryChen97
commented
Oct 10, 2024
|
Hi @lillian542 my implementation involved some refactoring over your previous design as well as some tests; fortunately all the tests seem smooth for now but I just want to double check to make sure there's no explicit missing point on my side |
mudit2812
reviewed
Oct 11, 2024
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
approved these changes
Oct 11, 2024
|
First PR almost in 🎉 ! |
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
austingmhuang
pushed a commit
that referenced
this pull request
Oct 23, 2024
**Context:** Currently, the sample_state helper function accepts a state vector, turns it into probabilities, and then samples it. This task is to break out the code for sample_probs from this function. By breaking this code into it's own helper function, we can reuse it for a "sample density matrix" implementation. **Description of the Change:** - [x] Separate `devices.qubit.sampling.sample_probs` from `sample_state` - [x] Separate `devices.qubit.sampling.sample_probs_jax` from `_sample_state_jax` - [x] similar but for qutrit mixed - [x] similar but for qutrit mixed **Benefits:** Better modularization; disentanglement Future usage in new devices **Possible Drawbacks:** **Related GitHub Issues:** **Related ShortCut Stories:** [sc-73317] --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
added a commit
that referenced
this pull request
Nov 11, 2024
**Context:** Currently, the sample_state helper function accepts a state vector, turns it into probabilities, and then samples it. This task is to break out the code for sample_probs from this function. By breaking this code into it's own helper function, we can reuse it for a "sample density matrix" implementation. **Description of the Change:** - [x] Separate `devices.qubit.sampling.sample_probs` from `sample_state` - [x] Separate `devices.qubit.sampling.sample_probs_jax` from `_sample_state_jax` - [x] similar but for qutrit mixed - [x] similar but for qutrit mixed **Benefits:** Better modularization; disentanglement Future usage in new devices **Possible Drawbacks:** **Related GitHub Issues:** **Related ShortCut Stories:** [sc-73317] --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently, the sample_state helper function accepts a state vector, turns it into probabilities, and then samples it. This task is to break out the code for sample_probs from this function.
By breaking this code into it's own helper function, we can reuse it for a "sample density matrix" implementation.
Description of the Change:
devices.qubit.sampling.sample_probsfromsample_statedevices.qubit.sampling.sample_probs_jaxfrom_sample_state_jaxBenefits:
Better modularization; disentanglement
Future usage in new devices
Possible Drawbacks:
Related GitHub Issues:
Related ShortCut Stories:
[sc-73317]