Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JIT tests for PL templates #6309

Merged
merged 83 commits into from
Oct 18, 2024
Merged

Adding JIT tests for PL templates #6309

merged 83 commits into from
Oct 18, 2024

Conversation

willjmax
Copy link
Contributor

This PR adds JIT tests for all templates that were missing JIT tests. This addresses [sc-73293].

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.38%. Comparing base (1bc346a) to head (e8571fa).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6309      +/-   ##
==========================================
- Coverage   99.40%   99.38%   -0.02%     
==========================================
  Files         447      447              
  Lines       42418    42418              
==========================================
- Hits        42164    42158       -6     
- Misses        254      260       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 😄 just a couple of comments

tests/templates/test_subroutines/test_aqft.py Outdated Show resolved Hide resolved
tests/templates/test_subroutines/test_flip_sign.py Outdated Show resolved Hide resolved
tests/templates/test_subroutines/test_grover.py Outdated Show resolved Hide resolved
tests/templates/test_subroutines/test_hilbert_schmidt.py Outdated Show resolved Hide resolved
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willjmax! Looks good, just a couple of minor suggestions.

tests/templates/test_embeddings/test_angle.py Show resolved Hide resolved
tests/templates/test_subroutines/test_interferometer.py Outdated Show resolved Hide resolved
tests/templates/test_subroutines/test_uccsd.py Outdated Show resolved Hide resolved
willjmax and others added 18 commits October 11, 2024 13:12
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
…rep.py

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willjmax, looks good to go. Please address my final minor points and I will approve.

tests/templates/test_embeddings/test_basis.py Outdated Show resolved Hide resolved
tests/templates/test_subroutines/test_hilbert_schmidt.py Outdated Show resolved Hide resolved
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willjmax, looks good!

@willjmax willjmax enabled auto-merge (squash) October 18, 2024 13:36
@willjmax willjmax merged commit 88caa8e into master Oct 18, 2024
40 checks passed
@willjmax willjmax deleted the jit-tests branch October 18, 2024 17:12
austingmhuang pushed a commit that referenced this pull request Oct 23, 2024
This PR adds JIT tests for all templates that were missing JIT tests.
This addresses [sc-73293].

---------

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
mudit2812 pushed a commit that referenced this pull request Nov 11, 2024
This PR adds JIT tests for all templates that were missing JIT tests.
This addresses [sc-73293].

---------

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants