-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding JIT tests for PL templates #6309
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6309 +/- ##
==========================================
- Coverage 99.40% 99.38% -0.02%
==========================================
Files 447 447
Lines 42418 42418
==========================================
- Hits 42164 42158 -6
- Misses 254 260 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 😄 just a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @willjmax! Looks good, just a couple of minor suggestions.
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
…rep.py Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @willjmax, looks good to go. Please address my final minor points and I will approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @willjmax, looks good!
This PR adds JIT tests for all templates that were missing JIT tests. This addresses [sc-73293]. --------- Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
This PR adds JIT tests for all templates that were missing JIT tests. This addresses [sc-73293]. --------- Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
This PR adds JIT tests for all templates that were missing JIT tests. This addresses [sc-73293].