Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qml.Qubitization QJIT compatible #6305

Merged
merged 26 commits into from
Oct 7, 2024
Merged

Make qml.Qubitization QJIT compatible #6305

merged 26 commits into from
Oct 7, 2024

Conversation

willjmax
Copy link
Contributor

Catalyst does not support passing a list of wires into the identity operator, so the following code causes a segmentation fault qml.Identity([0, 1]) To make this template QJIT compatible we need to build the Identity operator as a tensor product of single wire Identity operators instead of passing in a list of wires. This PR addresses [sc-74444].

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (c87a498) to head (c8c0eda).
Report is 334 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6305   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         445      446    +1     
  Lines       42315    42326   +11     
=======================================
+ Hits        42060    42071   +11     
  Misses        255      255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
@willjmax willjmax enabled auto-merge (squash) October 7, 2024 18:29
@willjmax willjmax merged commit 5c26faf into master Oct 7, 2024
37 checks passed
@willjmax willjmax deleted the qjit-qubitization branch October 7, 2024 20:29
austingmhuang pushed a commit that referenced this pull request Oct 23, 2024
Catalyst does not support passing a list of wires into the identity
operator, so the following code causes a segmentation fault
`qml.Identity([0, 1])` To make this template QJIT compatible we need to
build the Identity operator as a tensor product of single wire Identity
operators instead of passing in a list of wires. This PR addresses
[sc-74444].
willjmax added a commit to PennyLaneAI/catalyst that referenced this pull request Nov 13, 2024
This PR adds QJIT compatibility tests for all supported PL templates.
Some tests currently fail, and rely on fixes from the following
PennyLane PRs:
[#6305](PennyLaneAI/pennylane#6305),
[#6306](PennyLaneAI/pennylane#6306),
[#6307](PennyLaneAI/pennylane#6307). This PR
addresses [sc-72625].

---------

Co-authored-by: Guillermo Alonso-Linaje <65235481+KetpuntoG@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants