-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing ambiguity in PauliRot
error message.
#6298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
willjmax
changed the title
rewriting error message
Removing ambiguity in Sep 24, 2024
PauliRot
error message.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6298 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 444 444
Lines 42235 42235
=======================================
Hits 42112 42112
Misses 123 123 ☔ View full report in Codecov by Sentry. |
astralcai
approved these changes
Oct 1, 2024
lillian542
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
For the input of
PauliRot
the number of wires given must equal the length of the given Pauli word. Otherwise aValueError
is raised. For example,op = qml.PauliRot(0.5, "XY", wires=[0,1,2])
results inValueError: The given Pauli word has length 2, length 3 was expected for wires [0,1,2]
.However, this message can be ambiguous.
op = qml.PauliRot(0.5, "XYZZXYI", wires=[0])
raises the exceptionValueError: The given Pauli word has length 7, length 1 was expected for wires [0]
. It's unclear if "length 1" refers to the length of the Pauli word or the length of the wires.Description of the Change:
This PR changes the error message to remove the ambiguity. Now it will say
ValueError: The number of wires must be equal to the length of the Pauli Word. The Pauli word XY has length 2, and 3 wires were given [0, 1, 2].