-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply transform program to diagonalizing_gates in specs #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lillian542
changed the title
Apply preprocess to diagonalizing_gates in specs
Apply transform program to diagonalizing_gates in specs
Sep 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6290 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 445 445
Lines 42260 42263 +3
=======================================
+ Hits 42137 42140 +3
Misses 123 123 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Oct 2, 2024
albi3ro
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
astralcai
approved these changes
Oct 3, 2024
Co-authored-by: Christina Lee <christina@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
If the diagonalizing gates of a circuit contain unsupported gates, the decomposition isn't applied before deciding how many gates there are
Description of the Change:
We take the diagonalizing gates and apply the preprocess transform program (at the level specs was called with) on the gates before counting them for the
num_diagonalizing_gates
spec.Benefits:
The
num_diagonalizing_gates
spec respects thelevel
kwarg instead of always just returning the answer for the unprocessed version of the tape.[sc-64695]