DocFix: computing qml.jacobian for multiple measurement outcomes
#6283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qml.jacobian for multiple measurement outcomesqml.jacobian for multiple measurement outcomes
…o bugfix_jacobian_multiple_measurements
…o bugfix_jacobian_multiple_measurements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6283 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 444 444
Lines 42223 42223
=======================================
Hits 42100 42100
Misses 123 123 ☔ View full report in Codecov by Sentry. |
astralcai
approved these changes
Sep 30, 2024
dwierichs
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Nice fix, thanks @PietropaoloFrisoni 🎉
You could consider updating the PR title for future reference: It is a documentation upgrade and not a bug fix, right?
qml.jacobian for multiple measurement outcomesqml.jacobian for multiple measurement outcomes
PietropaoloFrisoni
added a commit
that referenced
this pull request
Oct 2, 2024
**Context:** While we use `from pennylane import numpy as pnp` internally in the code base, we should not use it for user-facing documentation. The current convention is: ``` from pennylane import numpy as np ``` **Description of the Change:** We revert the changes to the documentation introduced in #6283 and #6303 that violate such a principle. **Benefits:** Consistent convention across the documentation. **Possible Drawbacks:** None that I can think of **Related GitHub Issues:** None **Related Shortcut Stories:** [sc-74716] --------- Co-authored-by: dwierichs <david.wierichs@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The documentation for
qml.jacobianseems quite old and contains several examples that should be updated.Description of the Change: We updated the examples according to the meaning in the documentation. For instance, one example stated that the provided circuit outputs the probability for each basis state, while it was actually computing the expectation values of an operator.
Benefits: Better documentation with working examples.
Possible Drawbacks: None that I can think of.
Related GitHub Issues: #6259
Related Shortcut Stories: [sc-73557]