-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update casting for apply_operation
#6268
Conversation
Hello. You may have forgotten to update the changelog!
|
I'm going to open a temporary PR in |
4bc690e
to
0d2bf9b
Compare
Makes sense! Are these failures expected? |
@PietropaoloFrisoni In hindsight, I should've expected those failures. I've fixed them now by having a separate branch for casting when the interface is |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6268 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 444 444
Lines 42133 42202 +69
=======================================
+ Hits 42008 42079 +71
+ Misses 125 123 -2 ☔ View full report in Codecov by Sentry. |
* Update casting for matrices in `qml.devices.qubit.apply_operation`. For some reason the old casting was making jax happy but not autograd. * Remove the 0.38.1 changelog. @josh146 confirmed that we should do this now that the release has been yanked from PyPi.
qml.devices.qubit.apply_operation
. For some reason the old casting was making jax happy but not autograd.