Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FABLE template to return the correct result in JIT mode #6263

Merged
merged 15 commits into from
Sep 13, 2024

Conversation

willjmax
Copy link
Contributor

@willjmax willjmax commented Sep 12, 2024

This PR fixes bug #6262

Relevant Shortcut Stories:
[sc-73586]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@austingmhuang austingmhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this bug @willjmax. Small suggestion based on the theory of FABLE.

pennylane/templates/subroutines/fable.py Outdated Show resolved Hide resolved
Copy link
Contributor

@austingmhuang austingmhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! :) 🚀

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (30331fd) to head (403c7d4).
Report is 347 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6263      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files         444      444              
  Lines       42307    42321      +14     
==========================================
+ Hits        42137    42149      +12     
- Misses        170      172       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor non-blocking comment.

tests/templates/test_subroutines/test_fable.py Outdated Show resolved Hide resolved
@willjmax willjmax enabled auto-merge (squash) September 13, 2024 15:43
@willjmax willjmax merged commit 060bb9a into master Sep 13, 2024
37 checks passed
@willjmax willjmax deleted the fable-jit-bug branch September 13, 2024 15:53
mudit2812 pushed a commit that referenced this pull request Sep 16, 2024
mudit2812 pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants