Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qml.Qubitization wire order #6229

Merged
merged 33 commits into from
Sep 9, 2024
Merged

Qml.Qubitization wire order #6229

merged 33 commits into from
Sep 9, 2024

Conversation

KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Sep 6, 2024

Fix #6228

Relevant Shortcut Stories:
[sc-73121]

@KetpuntoG KetpuntoG changed the title Psp reformat Qml.Qubitization wire order Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (2113051) to head (edd3c2d).
Report is 344 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6229   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files         446      446           
  Lines       42492    42492           
=======================================
  Hits        42326    42326           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willjmax willjmax self-requested a review September 6, 2024 18:46
Copy link
Contributor

@willjmax willjmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@KetpuntoG KetpuntoG requested a review from Jaybsoni September 9, 2024 13:15
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, happy to approve

tests/templates/test_subroutines/test_qubitization.py Outdated Show resolved Hide resolved
@KetpuntoG KetpuntoG enabled auto-merge (squash) September 9, 2024 18:35
@KetpuntoG KetpuntoG merged commit c04e00e into master Sep 9, 2024
37 checks passed
@KetpuntoG KetpuntoG deleted the psp_reformat branch September 9, 2024 18:55
mudit2812 pushed a commit that referenced this pull request Sep 10, 2024
mudit2812 pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] qml.Qubitization set the wires differently from PrepSelPrep and Select
3 participants