Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build hamiltonians from custom lattices #6226

Merged
merged 96 commits into from
Sep 20, 2024
Merged

Build hamiltonians from custom lattices #6226

merged 96 commits into from
Sep 20, 2024

Conversation

austingmhuang
Copy link
Contributor

@austingmhuang austingmhuang marked this pull request as draft September 5, 2024 21:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (de54c54) to head (ae632f5).
Report is 356 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6226   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         444      444           
  Lines       42133    42226   +93     
=======================================
+ Hits        42008    42103   +95     
+ Misses        125      123    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ddhawan11 and others added 15 commits September 6, 2024 05:10
@ddhawan11 @austingmhuang
Update pennylane/spin/lattice.py
9f6e9e4 
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
@ddhawan11 @austingmhuang
Update pennylane/spin/spin_hamiltonian.py
f47b3ec 
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
@ddhawan11 @austingmhuang
Update pennylane/spin/lattice.py
902be92 
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
@ddhawan11 @austingmhuang
Update pennylane/spin/lattice.py
201fab9 
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
@ddhawan11
Merge branch 'master' into kitaev_model
17317b0
@ddhawan11
Addressed comments
d3ced11
@ddhawan11
Merge branch 'master' into kitaev_model
44491ba
@austingmhuang
draft tests and code
54624a5
@ddhawan11 @obliviateandsurrender
Update pennylane/spin/lattice.py
5386827 
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
@ddhawan11 @obliviateandsurrender
Update pennylane/spin/spin_hamiltonian.py
c285ec7 
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
@ddhawan11
fixed docstring for custom_edges
0972735
@ddhawan11
Fixed tests
60491e2
@ddhawan11
Updated changelog
af8c601
@ddhawan11
Documentation build fix
cd42fde
@austingmhuang
test for error
15b6222
@austingmhuang @obliviateandsurrender
Update tests/spin/test_lattice.py
9af9532 
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
obliviateandsurrender
obliviateandsurrender reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go from my end once these are addressed.

pennylane/spin/lattice.py Outdated Show resolved Hide resolved
pennylane/spin/spin_hamiltonian.py Show resolved Hide resolved
pennylane/spin/spin_hamiltonian.py Show resolved Hide resolved
tests/spin/test_spin_hamiltonian.py Show resolved Hide resolved
austingmhuang and others added 2 commits September 20, 2024 16:31
@austingmhuang @obliviateandsurrender
Update pennylane/spin/lattice.py
94df8e1 
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
@austingmhuang @obliviateandsurrender
Update pennylane/spin/spin_hamiltonian.py
66a5488 
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
obliviateandsurrender
obliviateandsurrender approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it with a last comment for the docs. Do remeber to include a changelog entry.

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved
austingmhuang and others added 2 commits September 20, 2024 17:04
@austingmhuang @obliviateandsurrender
Update pennylane/spin/spin_hamiltonian.py
465fbc4 
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
@austingmhuang
changelog entry
cc51482
@soranjh soranjh enabled auto-merge (squash) September 20, 2024 21:31
@soranjh soranjh merged commit f2e1e73 into master Sep 20, 2024
37 checks passed
@soranjh soranjh deleted the custom_lattice_function branch September 20, 2024 21:53
mudit2812 pushed a commit that referenced this pull request Sep 23, 2024
@austingmhuang @ddhawan11
@obliviateandsurrender @soranjh @mudit2812
Build hamiltonians from custom lattices (#6226)
e9c829d 
[sc-70985]

---------

Co-authored-by: ddhawan11 <ddhawan@umich.edu>
Co-authored-by: Diksha Dhawan <40900030+ddhawan11@users.noreply.github.com>
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soranjh soranjh soranjh approved these changes

@obliviateandsurrender obliviateandsurrender obliviateandsurrender approved these changes

@ddhawan11 ddhawan11 Awaiting requested review from ddhawan11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austingmhuang @obliviateandsurrender @soranjh @ddhawan11