Remove Python 3.9 in favour of 3.10 as minimum #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-65091] |
|
Hello. You may have forgotten to update the changelog!
|
|
Related works: PennyLaneAI/pennylane-lightning#891 PennyLaneAI/catalyst#1104 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6223 +/- ##
==========================================
- Coverage 99.65% 99.60% -0.06%
==========================================
Files 446 445 -1
Lines 42536 42362 -174
==========================================
- Hits 42390 42193 -197
- Misses 146 169 +23 ☔ View full report in Codecov by Sentry. |
|
Starting Python 3.10 we can use |
…nto dep/remove_py_39
…nto dep/remove_py_39
mlxd
commented
Sep 6, 2024
5 tasks
|
Note: all CI test labels will be updated before merging. |
mudit2812
approved these changes
Sep 6, 2024
|
Do we want to pin |
astralcai
approved these changes
Sep 6, 2024
Yep, good call. I'll add the label and retrigger. |
I think this is fine to leave free for now. |
mlxd
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Sep 6, 2024
**Context:** This PR removes support for Python 3.9 and migrates to 3.10 as the oldest supported version. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** PennyLaneAI/pennylane-lightning#891 PennyLaneAI/pennylane#6223
mudit2812
pushed a commit
that referenced
this pull request
Sep 10, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
test directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
- [x] The PennyLane source code conforms to
[PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
To lint modified files, simply `pip install pylint`, and then
run `pylint pennylane/path/to/file.py`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:** Remove Py 3.9 from the CI runners and package metadata.
**Description of the Change:**
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
mudit2812
pushed a commit
that referenced
this pull request
Sep 12, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
test directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
- [x] The PennyLane source code conforms to
[PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
To lint modified files, simply `pip install pylint`, and then
run `pylint pennylane/path/to/file.py`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:** Remove Py 3.9 from the CI runners and package metadata.
**Description of the Change:**
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Remove Py 3.9 from the CI runners and package metadata.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: