Qubitization reformat #6182
Merged
Qubitization reformat #6182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-71962] |
|
Pending on this issue to be solved |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6182 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 446 446
Lines 42536 42239 -297
==========================================
- Hits 42390 42092 -298
- Misses 146 147 +1 ☔ View full report in Codecov by Sentry. |
willjmax
reviewed
Sep 4, 2024
There was a problem hiding this comment.
@KetpuntoG Looks good other than one concern about the equality function
willjmax
approved these changes
Sep 5, 2024
obliviateandsurrender
requested changes
Sep 5, 2024
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
obliviateandsurrender
approved these changes
Sep 5, 2024
mudit2812
pushed a commit
that referenced
this pull request
Sep 10, 2024
This PR updates `Qubitization` to use `qml.PrepSelPrep`. It also fixes this [bug](#6175) Note that we are changing from decompose Qubitization in PrepSelPrep . Reflection to Reflection.PrepSelPrep --------- Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
mudit2812
pushed a commit
that referenced
this pull request
Sep 12, 2024
This PR updates `Qubitization` to use `qml.PrepSelPrep`. It also fixes this [bug](#6175) Note that we are changing from decompose Qubitization in PrepSelPrep . Reflection to Reflection.PrepSelPrep --------- Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
Qubitizationto useqml.PrepSelPrep. It also fixes this bugNote that we are changing from decompose Qubitization in PrepSelPrep . Reflection to Reflection.PrepSelPrep
Related GitHub Issues:
#6175
Related Shortcut Stories:
[sc-72403]