-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance for default.qubit.compute_vjp
#4841
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4841 +/- ##
==========================================
- Coverage 99.65% 99.64% -0.02%
==========================================
Files 387 387
Lines 35018 34772 -246
==========================================
- Hits 34898 34649 -249
- Misses 120 123 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @albi3ro .
Updated benchmarks:
|
[sc-51361] |
[sc-46350] For 10 qubits, 2 strongly entangling layers, and an expval on each wire: Before these changes: <img width="837" alt="Screenshot 2023-11-15 at 9 54 01 AM" src="https://github.com/PennyLaneAI/pennylane/assets/6364575/f8f08f51-700b-4e2d-9952-bed95a2eac2a"> After these changes: <img width="806" alt="Screenshot 2023-11-15 at 9 54 58 AM" src="https://github.com/PennyLaneAI/pennylane/assets/6364575/f94bfdc1-b0f8-44e8-ae3e-d5c67bb8e0f4">
[sc-46350]
For 10 qubits, 2 strongly entangling layers, and an expval on each wire:
Before these changes:
After these changes: