-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a base LKokkos new device API backend. #810
Conversation
…p and simulate_and_vjp
…ne-lightning into kokkosNewAPI_backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
===========================================
- Coverage 97.84% 74.67% -23.17%
===========================================
Files 117 20 -97
Lines 18658 2330 -16328
===========================================
- Hits 18255 1740 -16515
- Misses 403 590 +187 ☔ View full report in Codecov by Sentry. |
Thanks @LuisAlfredoNu ! Would you like to add a new entry to the .github/CHANGELOG.md file, summarizing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @LuisAlfredoNu . Not much to complain about at the moment. I'm adding the label "do not merge" to the PR since the description says this will be merged last. But feel free to add/remove whatever label you would like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some suggestions. I think it is better if you really keep the implementation here minimal. I think you left a lot of code that will probably need to be changed. Please, comment out all code that is not strictly necessary, and pass all tests.
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice job! Thank you for that, @LuisAlfredoNu!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🥳 Feel free to merge it after #884.
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Please complete the following checklist when submitting a PR: - [X] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [X] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [X] Ensure that the test suite passes, by running `make test`. - [X] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [X] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Following the design of *Lightning Qubit* uses the New Device API end to end, we can now migrate `lightning.kokkos` device to the new device API. **Description of the Change:** Migration of Lightning Kokkos to integrate the New device API. The list of main features changes are - Add the `state_vector`, `measurements`, and `adjoint-jacobian` classes for `lightning.kokkos` - Add the `simulate`, `jacobian`, `simulate_and_jacobian`, `vjp`, and `simulate_and_vjp` `methods to lighting.kokkos` - Update unit/integration tests for the new device API to work with `lightning.kokkos` - Check the full support for sampling in full parity with Lightning Qubit - Replace the old device API for Lightning Kokkos. **Benefits:** Full integration of **Lightning kokkos** with the new device API. **Possible Drawbacks:** **Related GitHub Issues:** [sc-59207], [sc-68825] --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
### Before submitting Please complete the following checklist when submitting a PR: - [X] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [X] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [X] Ensure that the test suite passes, by running `make test`. - [X] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [X] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Following the design of *Lightning Qubit* uses the New Device API end to end, we can now migrate `lightning.kokkos` device to the new device API. **Description of the Change:** Migration of Lightning Kokkos to integrate the New device API. The list of main features changes are - Add the `state_vector`, `measurements`, and `adjoint-jacobian` classes for `lightning.kokkos` - Add the `simulate`, `jacobian`, `simulate_and_jacobian`, `vjp`, and `simulate_and_vjp` `methods to lighting.kokkos` - Update unit/integration tests for the new device API to work with `lightning.kokkos` - Check the full support for sampling in full parity with Lightning Qubit - Replace the old device API for Lightning Kokkos. **Benefits:** Full integration of **Lightning kokkos** with the new device API. **Possible Drawbacks:** **Related GitHub Issues:** [sc-59207], [sc-68825] --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Following the design of Lightning Qubit uses the New Device API end to end, we can now migrate
lightning.kokkos
device to the new device API.Description of the Change:
Migration of Lightning Kokkos to integrate the New device API. The list of main features changes are
state_vector
,measurements
, andadjoint-jacobian
classes forlightning.kokkos
simulate
,jacobian
,simulate_and_jacobian
,vjp
, andsimulate_and_vjp
methods to lighting.kokkos
lightning.kokkos
Benefits:
Full integration of Lightning kokkos with the new device API.
Possible Drawbacks:
Related GitHub Issues:
[sc-59207], [sc-68825]